search

open-mmlab / mmdetection3d

OpenMMLab's next-generation platform for general 3D object detection.
https://mmdetection3d.readthedocs.io/en/latest/
Apache License 2.0
5k stars 1.49k forks source link

Fix rstrip bug in publish_model.py #2938

Open r-barnes opened 3 months ago

r-barnes commented 3 months ago

Motivation

.rstrip(".pth") will convert pthhtp.pth to the empty string. This is a bug.

removesuffix does the right thing, but works only from Python 3.10 up.

Modification

rstrip -> removesuffix

BC-breaking (Optional)

Only works with Python 3.10+.

Use cases (Optional)

N/A

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.
CLAassistant commented 3 months ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.