search

open-mmlab / mmeval

A unified evaluation library for multiple machine learning libraries
https://mmeval.readthedocs.io/en/latest/
Apache License 2.0
256 stars 49 forks source link

[Feat] Add COCOPoseMetric #97

Open LareinaM opened 1 year ago

LareinaM commented 1 year ago

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Add COCOPoseMetric for pose estimation task.

PR in mmpose: https://github.com/open-mmlab/mmpose/pull/1777, about the results verification.

Modification

  1. Add COCOPoseMetric under mmeval/metrics/coco_pose.py.
  2. Add some test data: tests/test_metrics/data/coco_pose_sample.json, tests/test_metrics/data/crowdpose_sample.json, tests/test_metrics/data/ap10k_sample.json and unit tests.
  3. Add nms function under mmeval/metrics/utils/nms.py.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repos? If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

Comments

  1. Change of examples in mmeval/metrics/coco_pose.py: add case and simplify input
  2. Fix all formats and typos
  3. add function aims at keeping consistent with that of COCODetection, and after discussion, no modification is made
  4. Indents in the files are implied by yapf hook