Norm the output of correlation_block

open-mmlab / mmflow

OpenMMLab optical flow toolbox and benchmark

https://mmflow.readthedocs.io/en/latest/

Apache License 2.0

958 stars 115 forks source link

Norm the output of correlation_block #115

Closed lhao0301 closed 2 years ago

lhao0301 commented 2 years ago

In this repo, the correlation output is not normalized(scale=False always), which is different from that in PWC & FlowNet repo. They normalize it by dimension. Hence, is it make little of importance?

https://github.com/open-mmlab/mmflow/blob/2f9871623f8b179a8920cfe067306c7d8b4848c0/mmflow/models/utils/correlation_block.py#L61-L68

MeowZheng commented 2 years ago

I have tested doing correlation normalization but found it made models difficult to coverage