open-mmlab / mmhuman3d

OpenMMLab 3D Human Parametric Model Toolbox and Benchmark
https://mmhuman3d.readthedocs.io/
Apache License 2.0
1.25k stars 137 forks source link

Update STAR lbs & render #355

Closed wendaizhou closed 1 year ago

wendaizhou commented 1 year ago
OpenMMLab-Assistant-004 commented 1 year ago

Hi @wendaizhou,

We'd like to express our appreciation for your valuable contributions to the mmhuman3d. Your efforts have significantly aided in enhancing the project's quality. It is our pleasure to invite you to join our community thorugh Discord_Special Interest Group (SIG) channel. This is a great place to share your experiences, discuss ideas, and connect with other like-minded people. To become a part of the SIG channel, send a message to the moderator, OpenMMLab, briefly introduce yourself and mention your open-source contributions in the #introductions channel. Our team will gladly facilitate your entry. We eagerly await your presence. Please follow this link to join us: ​https://discord.gg/UjgXkPWNqA.

If you're on WeChat, we'd also love for you to join our community there. Just add our assistant using the WeChat ID: openmmlabwx. When sending the friend request, remember to include the remark "mmsig + Github ID".

Thanks again for your awesome contribution, and we're excited to have you as part of our community!

wendaizhou commented 1 year ago

Hi, the code has been updated to fix these two problems.😊

caizhongang commented 1 year ago

Hi, the code has been updated to fix these two problems.😊

@wendaizhou Thanks for the fix. There's some additional problems in the build test:

=========================== short test summary info ============================
FAILED tests/test_models/test_body_models/test_star.py::test_star_specify_other_keypoint_mappings - AttributeError: 'NoneType' object has no attribute 'device'
FAILED tests/test_models/test_body_models/test_star.py::test_star_create_default_parameters - AttributeError: 'NoneType' object has no attribute 'device'
FAILED tests/test_models/test_body_models/test_star.py::test_star_init_parameters - AttributeError: 'NoneType' object has no attribute 'device'
FAILED tests/test_models/test_body_models/test_star.py::test_star_init_parameters_numpy - AttributeError: 'NoneType' object has no attribute 'device'
FAILED tests/test_models/test_body_models/test_star.py::test_star_forward_parameters - RuntimeError: shape '[1, 24, 3, 3]' is invalid for input of size 225
FAILED tests/test_models/test_body_models/test_star.py::test_star_init_and_forward_parameters - RuntimeError: shape '[1, 24, 3, 3]' is invalid for input of size 225

To run the test locally, you may set up the test files:

mkdir mmhuman3d_download
cd mmhuman3d_download
wget -O mmhuman3d.7z -q https://openmmlab-share.oss-cn-hangzhou.aliyuncs.com/mmhuman3d/mmhuman3d.7z
7za x mmhuman3d.7z
ls -l
cd ..
cp -r mmhuman3d_download/mmhuman3d/* ./
rm -rf mmhuman3d_download

and then run pytest:

pytest tests/test_models/test_body_models/test_star.py
codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 84.84% and project coverage change: -0.04 :warning:

Comparison is base (9edb211) 85.37% compared to head (1879aa3) 85.33%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #355 +/- ## ========================================== - Coverage 85.37% 85.33% -0.04% ========================================== Files 211 211 Lines 20213 20262 +49 ========================================== + Hits 17256 17290 +34 - Misses 2957 2972 +15 ``` | Flag | Coverage Ξ” | | |---|---|---| | unittests | `85.33% <84.84%> (-0.04%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-mmlab#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://app.codecov.io/gh/open-mmlab/mmhuman3d/pull/355?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-mmlab) | Coverage Ξ” | | |---|---|---| | [...mhuman3d/core/conventions/segmentation/\_\_init\_\_.py](https://app.codecov.io/gh/open-mmlab/mmhuman3d/pull/355?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-mmlab#diff-bW1odW1hbjNkL2NvcmUvY29udmVudGlvbnMvc2VnbWVudGF0aW9uL19faW5pdF9fLnB5) | `41.55% <25.00%> (-0.91%)` | :arrow_down: | | [mmhuman3d/core/visualization/visualize\_smpl.py](https://app.codecov.io/gh/open-mmlab/mmhuman3d/pull/355?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-mmlab#diff-bW1odW1hbjNkL2NvcmUvdmlzdWFsaXphdGlvbi92aXN1YWxpemVfc21wbC5weQ==) | `81.67% <44.44%> (-0.81%)` | :arrow_down: | | [mmhuman3d/models/body\_models/star.py](https://app.codecov.io/gh/open-mmlab/mmhuman3d/pull/355?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-mmlab#diff-bW1odW1hbjNkL21vZGVscy9ib2R5X21vZGVscy9zdGFyLnB5) | `98.71% <96.07%> (-1.29%)` | :arrow_down: | | [mmhuman3d/core/renderer/torch3d\_renderer/meshes.py](https://app.codecov.io/gh/open-mmlab/mmhuman3d/pull/355?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-mmlab#diff-bW1odW1hbjNkL2NvcmUvcmVuZGVyZXIvdG9yY2gzZF9yZW5kZXJlci9tZXNoZXMucHk=) | `87.04% <100.00%> (ΓΈ)` | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/open-mmlab/mmhuman3d/pull/355/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-mmlab)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

wendaizhou commented 1 year ago

Hi, thanks for the guidance. The bug mentioned in build test has been fixed, but I'm not sure if codecov in failing checks needs to be handled.

caizhongang commented 1 year ago

Hi, thanks for the guidance. The bug mentioned in build test has been fixed, but I'm not sure if codecov in failing checks needs to be handled.

>80% is fine. This PR looks good to me.