Closed wendaizhou closed 1 year ago
Hi @wendaizhou,
We'd like to express our appreciation for your valuable contributions to the mmhuman3d. Your efforts have significantly aided in enhancing the project's quality. It is our pleasure to invite you to join our community thorugh Discord_Special Interest Group (SIG) channel. This is a great place to share your experiences, discuss ideas, and connect with other like-minded people. To become a part of the SIG channel, send a message to the moderator, OpenMMLab, briefly introduce yourself and mention your open-source contributions in the #introductions channel. Our team will gladly facilitate your entry. We eagerly await your presence. Please follow this link to join us: βhttps://discord.gg/UjgXkPWNqA.
If you're on WeChat, we'd also love for you to join our community there. Just add our assistant using the WeChat ID: openmmlabwx. When sending the friend request, remember to include the remark "mmsig + Github ID".
Thanks again for your awesome contribution, and we're excited to have you as part of our community!
Hi, the code has been updated to fix these two problems.π
Hi, the code has been updated to fix these two problems.π
@wendaizhou Thanks for the fix. There's some additional problems in the build test:
=========================== short test summary info ============================
FAILED tests/test_models/test_body_models/test_star.py::test_star_specify_other_keypoint_mappings - AttributeError: 'NoneType' object has no attribute 'device'
FAILED tests/test_models/test_body_models/test_star.py::test_star_create_default_parameters - AttributeError: 'NoneType' object has no attribute 'device'
FAILED tests/test_models/test_body_models/test_star.py::test_star_init_parameters - AttributeError: 'NoneType' object has no attribute 'device'
FAILED tests/test_models/test_body_models/test_star.py::test_star_init_parameters_numpy - AttributeError: 'NoneType' object has no attribute 'device'
FAILED tests/test_models/test_body_models/test_star.py::test_star_forward_parameters - RuntimeError: shape '[1, 24, 3, 3]' is invalid for input of size 225
FAILED tests/test_models/test_body_models/test_star.py::test_star_init_and_forward_parameters - RuntimeError: shape '[1, 24, 3, 3]' is invalid for input of size 225
To run the test locally, you may set up the test files:
mkdir mmhuman3d_download
cd mmhuman3d_download
wget -O mmhuman3d.7z -q https://openmmlab-share.oss-cn-hangzhou.aliyuncs.com/mmhuman3d/mmhuman3d.7z
7za x mmhuman3d.7z
ls -l
cd ..
cp -r mmhuman3d_download/mmhuman3d/* ./
rm -rf mmhuman3d_download
and then run pytest:
pytest tests/test_models/test_body_models/test_star.py
Patch coverage: 84.84
% and project coverage change: -0.04
:warning:
Comparison is base (
9edb211
) 85.37% compared to head (1879aa3
) 85.33%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Hi, thanks for the guidance. The bug mentioned in build test
has been fixed, but I'm not sure if codecov
in failing checks needs to be handled.
Hi, thanks for the guidance. The bug mentioned in
build test
has been fixed, but I'm not sure ifcodecov
in failing checks needs to be handled.
>80% is fine. This PR looks good to me.