open-mmlab / mmsegmentation

OpenMMLab Semantic Segmentation Toolbox and Benchmark.
https://mmsegmentation.readthedocs.io/en/main/
Apache License 2.0
7.69k stars 2.53k forks source link

Make mmseg to be able to run on mmcv=2.2.0 #3663

Open rabinadk1 opened 1 month ago

rabinadk1 commented 1 month ago

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

The documentation says it is okay to run with mmcv >= 2.2.0, but mmseg incorrectly asserts it to be less than 2.2.0.

Modification

  1. Allow mmcv with version 2.2.0 to run with the latest mmseg package.
  2. Separate the assertion for the package version checks into two statements to provide users with clear feedback on whether their version is less or more than the required range.

BC-breaking (Optional)

No

Use cases (Optional)

N/A

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMDet3D.
  4. The documentation has been modified accordingly, like docstring or example tutorials.
CLAassistant commented 1 month ago

CLA assistant check
All committers have signed the CLA.