search

open-mmlab / mmsegmentation

OpenMMLab Semantic Segmentation Toolbox and Benchmark.
https://mmsegmentation.readthedocs.io/en/main/
Apache License 2.0
7.68k stars 2.53k forks source link

Missing split Argument in BaseSegDataset Class #3693

Open yasserben opened 3 weeks ago

yasserben commented 3 weeks ago

Hello !

I noticed that in the migration from version 0.x to 1.x, the BaseSegDataset class (which is the new version of CustomDataset from 0.x) is missing the splitargument. The split argument is crucial for selecting files from a dataset according to the filenames specified in the file provided by this argument.

Moreover, the docstring of the BaseSegDataset class still mentions the splitargument, but it is not actually implemented or considered in the class. https://github.com/open-mmlab/mmsegmentation/blob/b040e147adfa027bbc071b624bedf0ae84dfc922/mmseg/datasets/basesegdataset.py#L13-L42

Thanks !