open-mmlab / mmselfsup

OpenMMLab Self-Supervised Learning Toolbox and Benchmark
https://mmselfsup.readthedocs.io/en/latest/
Apache License 2.0
3.18k stars 428 forks source link

T-SNE TypeError: 'int' object is not iterable bug fix #708

Closed guneetmutreja closed 1 year ago

guneetmutreja commented 1 year ago

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

T-SNE with resnet 50 backbone throws the error mentioned in: #696

Modification

Modified the int type out_indices in the config to tuple type.

BC-breaking (Optional)

Does the modification introduce changes that break the backward compatibility of the downstream repositories? If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here and update the documentation.

Checklist

Before PR:

After PR:

fangyixiao18 commented 1 year ago

Hello, thanks for your contribution, please run pre-commit to fix the lint error

guneetmutreja commented 1 year ago

@fangyixiao18 Thank you for the suggestion. I ran the pre-commit and it passed lint workflow.