open-mpi / mtt

MPI Testing Tool
https://open-mpi.github.io/mtt
Other
61 stars 47 forks source link

MTT Reporter needs to escape special characters in SQL queries #391

Open ompiteam opened 9 years ago

ompiteam commented 9 years ago

In the below MTT report, clicking on any of the red failure squares incorrectly opens up a 0 results page:

http://www.open-mpi.org/mtt/index.php?do_redir=1189

Adding &sql=2&debug=on to the URL reveals the following problematic SQL:

{{{ ... (configure_arguments ~* 'CFLAGS=-g -pipe') AND (configure_arguments !~* '-enable-picky') AND (configure_arguments !~* '-enable-debug') AND (configure_arguments !~* '-enable-mpirun-prefix-by-default') ... }}}

The " and - characters have special meaning (see [wiki:WebUIGuide]), and in the above case - report.php misinterprets them.

ompiteam commented 9 years ago

Imported from trac issue 390. Created by emallove on 2010-01-13T15:44:39, last modified: 2010-01-25T16:53:00

ompiteam commented 9 years ago

Trac comment by emallove on 2010-01-25 16:53:00:

More of the same issue here, this time with ( and ) chars: http://www.open-mpi.org/mtt/index.php?do_redir=1200