open-mpi / ompi

Open MPI main development repository
https://www.open-mpi.org
Other
2.13k stars 858 forks source link

UCX: Propagate MPI serialized for all worker creations #12608

Closed tvegas1 closed 3 months ago

tvegas1 commented 3 months ago

replaces first v5.0.x backport #12579

cherry-pick from main #12577 and #12590

What

The UCX PML needs to differentiate between mpi serialized and single thread mode according to MPI standard.

Why

Using UCX with multiple threads, even when providing mutual exclusion, is not completely equivalent to only using UCX with one same thread.

To guarantee ordering and avoid corruption, some UCX transports need the cpu to flush stores to the devices, before another thread can progress the worker. For latency reasons, this needed flush is only performed in non single thread mode.

github-actions[bot] commented 3 months ago

Hello! The Git Commit Checker CI bot found a few problems with this PR:

637b40ea: UCX: Propagate MPI serialized for all worker creat...

df838c79: pml/ucx: Propagate MPI serialized thread mode

Please fix these problems and, if necessary, force-push new commits back up to the PR branch. Thanks!

tvegas1 commented 3 months ago

@brminich, @bosilca, @yosefe, can you please review?