search

open-mpi / ompi

Open MPI main development repository
https://www.open-mpi.org
Other
2.07k stars 844 forks source link

dist/buildrpm: fix incorrect test, which passed even with an empty path #12622

Closed alex--m closed 2 weeks ago

alex--m commented 2 weeks ago

Stumbled on this by accident - turns out this condition is true and proceeds the then clause even if the libfabric_path was never set and remained empty. Adding the quotes fixes this, so that only non-empty string (set by passing -f to buildrpm.sh) would trigger the rest of libfabric detection logic (as probably intended originally).

As the code runs today - every build adds these (libfabric-specific?) flags to the configure phase of the build - for no apparent reason: LDFLAGS=-Wl,--build-id -Wl,-rpath -Wl,/lib64 -Wl,--enable-new-dtags

alex--m commented 2 weeks ago

Tagging @martinkontsek and @jsquyres - who are probably the best candidates to review this

jsquyres commented 2 weeks ago

@alex--m Can you cherry-pick this to v5.0.x? Thanks!

alex--m commented 2 weeks ago

@alex--m Can you cherry-pick this to v5.0.x? Thanks!

Posted #12630 and #12631