search

open-mpi / ompi

Open MPI main development repository
https://www.open-mpi.org
Other
2.07k stars 844 forks source link

Remove script wrappers in v6.0.x #12625

Open jsquyres opened 2 weeks ago

jsquyres commented 2 weeks ago

Hey @hppritcha is there a reason that we still need to keep carrying the script wrappers to v6.0.x and beyond?

They are not installed by default, but periodically someone does try and sometimes they do cause work (e.g., https://github.com/open-mpi/ompi/issues/12609). Does DOE still use the script wrappers for cross-compilation, or other reasons?

minrk commented 2 weeks ago

FWIW, we are exploring the script wrappers for cross compilation in Conda-forge, which prompted #12609. This is motivated largely by the fact that cross compilation for mpich has been far simpler for us because mpich compiler wrappers are scripts instead of binaries. We do have cross compilation working with openmpi, so we will probably skip migrating to the script wrappers if they are going to go away anyway.

jsquyres commented 2 weeks ago

@minrk Ok, great. Please keep us informed; we can keep the script wrappers (especially if they're working ok) -- my main motivation in filing this issue was that we probably haven't tested these scripts in years. If they're still working fine, that's good!

hppritcha commented 2 weeks ago

pinged some folks about this.