v4.1.x: ompi/coll/cuda: implement reduce_local

open-mpi / ompi

Open MPI main development repository

https://www.open-mpi.org

Other

2.17k stars 861 forks source link

v4.1.x: ompi/coll/cuda: implement reduce_local #12752

Closed Akshay-Venkatesh closed 1 month ago

Akshay-Venkatesh commented 3 months ago

Reduce_local implementation is missing which causes failures in IMB. The implementation piggybacks on existing cuda reduce implementation to stage/unstage send/receive buffers.

bot:notacherrypick

github-actions[bot] commented 3 months ago

Hello! The Git Commit Checker CI bot found a few problems with this PR:

050b1ed4: ompi/coll/cuda: implement reduce_local

check_cherry_pick: does not include a cherry pick message (did you need to bot:notacherrypick?)

Please fix these problems and, if necessary, force-push new commits back up to the PR branch. Thanks!

jsquyres commented 3 months ago

This looks related to https://github.com/open-mpi/ompi/pull/12758, even though the file paths have changed.

Should probably resolve the discussion there first before merging here.

I took the liberty of converting this to Draft so that it's not accidentally merged.