search

open-mpi / ompi

Open MPI main development repository
https://www.open-mpi.org
Other
2.17k stars 861 forks source link

opal/cuda: Handle CUDA VMM pointers in accelerator check_addr function #12757

Closed Akshay-Venkatesh closed 2 months ago

Akshay-Venkatesh commented 3 months ago

Support CUDA VMM pointers

jsquyres commented 3 months ago

@Akshay-Venkatesh Why did you put bot:notacherrypick on this PR?

Akshay-Venkatesh commented 3 months ago

@Akshay-Venkatesh Why did you put bot:notacherrypick on this PR?

@jsquyres I've addressed this now

jsquyres commented 3 months ago

@Akshay-Venkatesh Why did you put bot:notacherrypick on this PR?

@jsquyres I've addressed this now

I still see bot:notacherrypick in the description of this PR.

You can find a description of what bot:notacherrypick is supposed to be used for in https://docs.open-mpi.org/en/v5.0.x/developers/git-github.html#git-branch-scheme. Please use it approrpiately.

Akshay-Venkatesh commented 2 months ago

I left comments on the PR for the 4.1. Please address them here as well

@bosilca Thanks for catching the leaked handle. I've made relevant fixes to handle VMM pointers in general. Please review when you get a chance and thanks in advance.

janjust commented 2 months ago

@Akshay-Venkatesh please squash commits and force push, I'll cherry-pick to v5.0.x