open-mpi / ompi

Open MPI main development repository
https://www.open-mpi.org
Other
2.14k stars 859 forks source link

[patch] openmpi 5.0.5 header relative path correction #12814

Open ksalerno99 opened 1 month ago

ksalerno99 commented 1 month ago

Thank you for taking the time to submit an issue!

Background information

Compiling for AIX where there is no asprintf or vasprintf so the OpenPMIx header check condition in pmix_config_bottom.h to include pmix_printf.h is true - only problem is the relative path to src/util/pmix_printf.h is missing the first directory, src, so the configure script check cannot find it looking for util/pmix_printf.h.

What version of Open MPI are you using? (e.g., v4.1.6, v5.0.1, git branch name and hash, etc.)

5.0.5 stable

Describe how Open MPI was installed (e.g., from a source/distribution tarball, from a git clone, from an operating system distribution package, etc.)

source tarball

If you are building/installing from a git clone, please copy-n-paste the output from git submodule status.

Please describe the system on which you are running


Details of the problem

Please describe, in detail, the problem that you are having, including the behavior you expect to see, the actual behavior that you are seeing, steps to reproduce the problem, etc. It is most helpful if you can attach a small program that a developer can use to reproduce your problem.

configure test for pmix_argv.h fails when pmix_config_bottom.h tries to include pmix_printf.h missing part of its relative path

ksalerno99 commented 1 month ago

Patch to fix the issue:

diff -ru a/3rd-party/openpmix/src/include/pmix_config_bottom.h b/3rd-party/openpmix/src/include/pmix_config_bottom.h
--- a/3rd-party/openpmix/src/include/pmix_config_bottom.h       2024-09-16 20:15:16.169882067 -0400
+++ b/3rd-party/openpmix/src/include/pmix_config_bottom.h       2024-09-16 20:15:50.958914221 -0400
@@ -422,7 +422,7 @@

 #    if !defined(HAVE_ASPRINTF) || !defined(HAVE_SNPRINTF) || !defined(HAVE_VASPRINTF) \
         || !defined(HAVE_VSNPRINTF)
-#        include "util/pmix_printf.h"
+#        include "src/util/pmix_printf.h"
 #    endif

 #    ifndef HAVE_ASPRINTF
rhc54 commented 1 month ago

Thanks for the patch! To be honest, I didn't realize AIX still existed 🤷‍♂️ Good to know!