search

open-mpi / ompi

Open MPI main development repository
https://www.open-mpi.org
Other
2.16k stars 859 forks source link

Nightly snapshot tarball filename problematic for RPMs #3394

Open jsquyres opened 7 years ago

jsquyres commented 7 years ago

Per https://www.mail-archive.com/devel@lists.open-mpi.org/msg20095.html, Kevin Buckley reports that the additional - characters in the nightly tarball filename makes RPM complain. I.e.:

Version: v2.0.x-201704190318-24b5b83

in the specfile will cause RPM to complain something like this:

error: line 188: Illegal char '-' in: Version: v2.0.x-201704190318-24b5b83

Kevin suggests renaming the nightly tarballs to use dots instead of dashes (e.g., Version: v2.0.x.201704190318.24b5b83).

I can't think of a reason why using dots instead of dashes would cause an issue for us -- @bwbarrett can you think of a reason why we shouldn't make this change?

bwbarrett commented 7 years ago

Shouldn't bother anything with the nightly builder bits, I think we should just have to update autogen/configure where we build that string?