open-mpi / ompi

Open MPI main development repository
https://www.open-mpi.org
Other
2.17k stars 860 forks source link

Remove all the rest of the FT code #7437

Closed jsquyres closed 3 years ago

jsquyres commented 4 years ago

There's still a bunch of FT things left over in the code base that should be removed:

bosilca commented 4 years ago

Not all of them are related to C/R. ULFM uses quite a few, so the removal should be done carefully.

jsquyres commented 4 years ago

Gotcha.

Of the list above, can you identify what ULFM is using?

bosilca commented 4 years ago

@abouteiller.

abouteiller commented 4 years ago

Can be removed without side effects on ULFM:

  1. opal/tools/*: we do not use at all.
  2. WANT_FT_CR: we do not use, can remove all blocks of code between ifdef ENABLE_FT_CR
  3. WANT_FT_THREAD/ENABLE_FT_THREAD: this pertains only to opal/runtime/opal_cr.[ch]. We do not use.

What we need to KEEP:

  1. config/opal_setup_ft.m4: NEEDED. We reuse most of the logic to add the FT_MPI case alongside the FT_CR case. We do not use any of the logic for WANT_FT_THREAD.
  2. some schizo specific behavior about --enable-recovery, and the mpirun/orte logic to handle persistent DVM/PRRTE).
jsquyres commented 3 years ago

Cross-reference this against #7740.

jjhursey commented 3 years ago

Things to remove

jjhursey commented 3 years ago

PR #8311 should resolve this issue.

jjhursey commented 3 years ago

PR #8312 has been merged. This can be closed