search

open-mpi / ompi

Open MPI main development repository
https://www.open-mpi.org
Other
2.09k stars 846 forks source link

#procs limit hardcoded in Intel tests and not checked. #98

Open ompiteam opened 9 years ago

ompiteam commented 9 years ago

If you run intel_tests/src/MPI_Alltoallv_f, it hangs above 64 procs. If you check

% grep MAX_RANKS intel_tests/src/*.h

you'll see that MAX_RANKS is hardwired to 64. I suppose that's okay, but there is no run-time check. If we're going to have hard-wired limits, at least the tests should check that, say, the size of MPI_COMM_WORLD does not exceed MAX_RANKS. I could add such a check to MPI_Alltoallv_f.F, but perhaps someone who understands the tests better can implement a broader, a more universal, fix.

For scalability, it might also be nice to have the number of tests scaled down for large runs. E.g., see what is done for C tests with

% grep LARGE_CLUSTER intel_tests/src/*.h

ompiteam commented 9 years ago

Imported from trac issue 2203. Created by eugene on 2010-01-28T15:30:20, last modified: 2012-10-10T17:51:53

ompiteam commented 9 years ago

Trac comment by eugene on 2010-01-28 16:09:30:

The Fortran limit has been bumped up from MAX_RANKS=64 to 256 in r1760. It's still a hard limit, though, and there are no run-time limit checks. The C tests are still governed by -DLARGE_CLUSTER.

ompiteam commented 9 years ago

Trac comment by bbenton on 2012-02-21 13:40:41:

Milestone Open MPI 1.4.5 deleted

ompiteam commented 9 years ago

Trac comment by bbenton on 2012-10-10 17:51:53:

Passing along to 1.6 series.