MPI 4.1: add support for memory-alloc-kinds

open-mpi / prrte

PMIx Reference RunTime Environment (PRRTE) - OMPI fork

https://pmix.org

Other

1 stars 1 forks source link

MPI 4.1: add support for memory-alloc-kinds #1

Closed hppritcha closed 2 months ago

hppritcha commented 4 months ago

MPI 4.1: add support for memory-alloc-kinds Changes will need to be made to Open MPI to parse the contents of the OMPI_MCA_mpi_memory_alloc_kinds environment variable to determine how to use the user supplied memory-alloc-kinds information.

See section 11.4.3 of the MPI 4.1 standard.

Signed-off-by: Howard Pritchard howardp@lanl.gov (cherry picked from commit https://github.com/open-mpi/prrte/commit/c5953e13bdc76b4a1f37c6bba1a11b26d557a22b)

janjust commented 4 months ago

Probably need to add CI. At the very least github actions. And maybe a description about this PR since it was discussed at the dev. meeting?

hppritcha commented 4 months ago

i'll open a separate pr to add some of the upstream ci sanity checks then rebase this one. the description is a little light because its to commits. I'll fix that up.

naughtont3 commented 4 months ago

@hppritcha Quick sanity check looked good. Also, skimmed MPI-4.1 and do not recall how we intended to reflect valid values that can be passed here. Added complication being that mpirun --help just tells us to look at mpirun(1).

rhc54 commented 4 months ago

FWIW: I found a few in one doc: system,mpi,rocm:device. No idea what the complete list looks like - if someone can pass it along, I can add to the help output.

github-actions[bot] commented 2 months ago

Hello! The Git Commit Checker CI bot found a few problems with this PR:

8ee4753a: MPI 4.1: add support for memory-alloc-kinds

check_cherry_pick: contains a cherry pick message that refers to a commit that exists, but is in an as-yet unmerged pull request: c5953e13bdc76b4a1f37c6bba1a11b26d557a22b

Please fix these problems and, if necessary, force-push new commits back up to the PR branch. Thanks!