search

open-mpic / draft-mpic

Other
2 stars 1 forks source link

ACME-specific methods #19

Open birgelee opened 2 months ago

birgelee commented 2 months ago

https://github.com/open-mpic/draft-mpic/blob/42ee5bf17254cf81efa879cfee2bd1b51fa8c718/draft-westerbaan-secdispatch-mpic.md?plain=1#L187

Upon reviewing the BRs and the ACME RFC, I plan to rework the open mpic API to separate agreed website change v2 and ACME agreed website change as separate methods. I know this came up previously and I sided on keeping them as a single method, but I have changed my mind a bit upon more review of the RFC and BRs. I will put a more detailed discussion in the Open MPIC repo when I make a PR for the change. Just a heads up.

bwesterb commented 2 months ago

What is the reasoning for the change of heart?

birgelee commented 2 months ago

I put in some discussion in the aws-paython-lambda repo: https://github.com/open-mpic/aws-lambda-python/issues/13#issue-2531872132

Essentially the standard seems to clearly identify these as two separate methods that actually have fairly significant differences in how to properly execute validation. It is not clear to me upon further review of the standards that a single back end engine could appropriately handle both methods without it simply being two methods under the hood masquerading as a single method. I know this is somewhat contrary to recommendations I made earlier but I had not realized the extent to which these two methods contradicted.

bwesterb commented 2 months ago

Maybe I'm missing something, but we could still use a single method if the API returns the quorum value of the file, and only accesses on HTTP?