open-nomie / nomie6-oss

Opensource version of Nomie 6
MIT License
509 stars 60 forks source link

Enhancement: 51 stats option for line bar charts #54

Closed RdeLange closed 1 year ago

RdeLange commented 1 year ago

Addressing #51 .... and as a bonus fix the buggy Also Include and make the Also Include persistent

Testing:

Statistics

Also Include

netlify[bot] commented 1 year ago

Deploy Preview for nomie6-oss ready!

Name Link
Latest commit 8f23370ef0433dd2415db65bbd204d8ca32efd72
Latest deploy log https://app.netlify.com/sites/nomie6-oss/deploys/63ef23e5c144fa0008d754c6
Deploy Preview https://deploy-preview-54--nomie6-oss.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

donalmacanri commented 1 year ago

This looks really promising! I will hopefully get some time to dig into it tomorrow.

RdeLange commented 1 year ago

I will adjust 1 small thing: the statistics line is having datapoint dots. I don’t like that and it is not needed so I will do a small code update later today

RdeLange commented 1 year ago

Done

donalmacanri commented 1 year ago

Sorry, it's been a mad week. I will get to this tomorrow, looking forward to it.

RdeLange commented 1 year ago

Don’t worry, first things first

donalmacanri commented 1 year ago

Features like this remind me that we could really use a good fake data set for testing with. Nevertheless, I managed to test it all with a very small data set on desktop and mobile, and all is well. This is a really useful addition. LGTM!