open-numbers / ddf--gapminder--systema_globalis

Gapminder's fact-base with local & global statistics
99 stars 82 forks source link

Add gapminder co2 per capita data from gapminder dataset #26

Open jheeffer opened 7 years ago

jheeffer commented 7 years ago

We'll fix the whole pipeline source to end

  1. ddf--cdiac--co2 https://github.com/open-numbers/ddf--cdiac--co2/issues/3 Clean up CDIAC units https://github.com/open-numbers/ddf--cdiac--co2/issues/4 Clean up CDIAC definitions & versions
  2. ddf--gapminder--co2_emission https://github.com/open-numbers/ddf--gapminder--co2_emission/issues/1 Fix entity mapping to geo https://github.com/open-numbers/ddf--gapminder--co2_emission/issues/2 Add all indicators

Then for Systema Globalis:

  1. replace the GW indicators mentioned in https://github.com/open-numbers/ddf--gapminder--co2_emission/issues/2 with ddf--gapminder--co2_emission indicators
  2. Remove yearly_co2_emissions_tonnes from SG. (remove from GW and CDIAC recipes)

For co2_emissions_tonnes_per_person make sure that

For all make sure that

semio commented 7 years ago

For descriptions of concepts, if they are not correct in old GW, can you provide a correct version?

Below are my suggestions, do they look good?

jheeffer commented 7 years ago

Good suggestions, I corrected a bit, added per capita to the first one and explicit metric tons (US english is our standard).

co2_emissions_tonnes_per_person name: CO2 per capita unit: metric tons per person description: Per capita carbon dioxide emissions from fossil fuel consumption, cement production and gas flaring (metric tons of CO2 per person).

yearly_co2_emissions_1000_tonnes name: Yearly CO2 emissions unit: 1000 metric tons description: Total carbon dioxide emissions from fossil fuel consumption, cement production and gas flaring during the given year (1000 metric tons of CO2).

cumulative_co2_emissions_tonnes name: Cumulative CO2 emissions unit: metric tons description: Cumulative carbon dioxide emissions from fossil fuel consumption, cement production and gas flaring for the period between 1751 and the relevant year (metric tons of CO2).

jheeffer commented 7 years ago

I saw you added removal of yearly_co2_emissions_tonnes through a patch. It's good for now.

Did you consider to just not include it in the GW ingredient?

https://github.com/semio/ddf--gapminder--systema_globalis/blob/master/etl/recipes/recipe_main.yaml#L43-L46

      dataset: ddf--gapminder--gapminder_world
      key: "geo,time"
      value: "*"

instead of * have a list of all Gapminder World indicators and not include yearly_co2_emissions_tonnes.

I'm not sure if this is the right way, biiiiiiig list, maybe a recipe procedure is better..? https://github.com/semio/ddf_utils/issues/33 (filter_column) would be perfect of course.