Add maxhgap param and code to support it to weill()

open-ocean-sounding / echopy

Fisheries acoustic data processing in Python

MIT License

10 stars 7 forks source link

Add maxhgap param and code to support it to weill() #2

Closed nhanitvn closed 3 years ago

nhanitvn commented 3 years ago

Hi @alejandro-ariza, we at Arimo found the echopy library very useful in a project with a fish finder manufacturer. We updated the weill() implementation to support the maxhgap parameter. Could you take a look to see if it is OK or if there is any code that needs to be fixed before merging? Thanks!!!

alejandro-ariza commented 3 years ago

Excellent @nhanitvn! I just set maxhgap to zero, so it's not applicable by default, horizontal gaps were not described/permitted in Weill et al (1993). It's nice to increase functionality in algorithms, as long as we make clear it's an "extra", not implemented in the original algorithm. If too different we can always create new algorithms.

Thanks for your contribution!

nhanitvn commented 3 years ago

Thanks @alejandro-ariza for maintaining such a great software :)