search

open-olive / loop-development-kit

The JavaScript/TypeScript Loop Development Kit for Olive Helps.
MIT License
20 stars 18 forks source link

CustomHeight no longer being honored OH v0.30.2 LDK 3.10.1 #501

Closed IanKrieger closed 1 year ago

IanKrieger commented 2 years ago

Had a few <oh-box> ... elements using CustomHeight param.

On update to new version of OH, the custom height param seems to no longer be honored, and downgrading does not fix.

Before

Screen Shot 2022-01-18 at 2 43 52 PM

After

Screen Shot 2022-01-21 at 10 22 27 AM
MaggieMaSS commented 2 years ago

@IanKrieger Thanks for the feedback! We made the scroll component height dynamic. And instead of setting a fixed heigh, we set a fixed max-height. for better user experience.

According to our chat on circulo channel, I'm going to create a feature request ticket for this issue. I'll discuss this with my teammates and the ideal solution would be user able to choose to use a custom height to create a fixed component, or choose to use dynamic height component.

Linked ticket : HELPS-3149

MaggieMaSS commented 2 years ago

Thanks for your feedback! This issue has been fixed on Olive Helps 0.34.4 :)