open-olive / loop-development-kit

The JavaScript/TypeScript Loop Development Kit for Olive Helps.
MIT License
20 stars 18 forks source link

[BUG] Wrong Message. #564

Open alokmishra1 opened 2 years ago

alokmishra1 commented 2 years ago

We are creating a few links. These links do not point to any web URL. When we hover over these links we get a hover message like this “Invalid link address”.

image

This message is creating a bad experience. We don’t need this message but in LDK we don’t have any option to avoid this message.

Please help in avoiding this message.

racary-olive commented 2 years ago

Thanks for reporting @alokmishra1! Could you provide an example of your loop code and what version of Olive Helps you are running?

iangallOlive commented 2 years ago

Hi there! Thanks so much for reporting this. In the future, please provide information for everything requested in the description template so we can get all the information needed upfront. I understand you've generally provided everything, but we'd like to follow our templates.

alokmishra1 commented 2 years ago

I am creating link in Markdown like this markdownTopic += "|● [${jData.name}] \n"; After this we are implementing onLinkClick() Method. let markdown1 = { body: markdownTopic, type: WhisperComponentType.Markdown, onLinkClick: (error, linkName) => { console.info(Received click on the link: ${JSON.stringify(linkName)}); console.info('error=============', JSON.stringify(error)); linkName = linkName.trim(); let sdata = allData.filter((element, k) => { if (element['S.No'] >= 4) { let jData = element['JSON'] ? JSON.parse(element['JSON']) : '{}'; if (jData.name && jData.name.toLowerCase() == linkName.toLowerCase()) { return true; } } }); this.showResult(sdata[0], 'topic', 0, 0, allData); }, };

in onLinkClick method we are using linkName and doing some task on click of link.

These links do not point to any web URL. When we hover over these links we get a hover message like this “Invalid link address”. This message is creating a bad experience. We don’t need this message but in LDK we don’t have any option to avoid this message. Please help in avoiding this message.

alex-merkert-olive commented 2 years ago

I'm going to change this to a Feature Request since this is intended behavior for links without a url. We are investigating some solutions for this scenario, and we'll keep you up to date through this issue when we come to a decision.

alokmishra1 commented 2 years ago

Hi Team, I just wanted to know, what is the status of this feature request. Thanks, Alok