search

open-ortho / dcm4ceph

Convert Cephalograms from JPEG to DICOM.
MIT License
0 stars 2 forks source link

Feature/gh release #14

Closed tttomat19 closed 1 year ago

tttomat19 commented 1 year ago

Hi Toni,

Here's automated release PR. Maybe like a first draft of it.

Notice: Branch is created from feature/upd_build branch. So the diff is huge until feature/upd_build is merged.

The files changed.

  1. .github/workflows/release.yml
  2. ./dcm4ceph-tool/pom.xml ant script
  3. 2 scripts in dcm4ceph-dist/

The release process is triggered by pushing a tag starting with "v". E.g v1.0.0

The result of the release is:

  1. dcm4ceph-dist.zip file with jar, 2 scripts to run and sample data. I thought it was better than just a jar. Basically only jar is not usable, but the whole package with examples is better.
  2. source zip and tar (default)
  3. Not here yet, but I'll add -source and -javadoc jars generated for core library.
tttomat19 commented 1 year ago

Fixed that by syncing my fork's develop branch. That did not work as I said initially, because there are 2 repos, fork and original.

tttomat19 commented 1 year ago

Hi Toni, to see automated release in action for open-ortho the branch needs to be merged to open-ortho version of repo.

It must be done just to pull the code with the release workflow yml file.

Then one needs to push v* tag to the repository.

Pushing the tag is not restricted to the master branch, pushing to whatever branch will also trigger the release.

After pushing you may find the release build logs in repo settings.

Here I tested the process with my fork: https://github.com/tttomat19/dcm4ceph/releases/tag/v0.9.0-5

zgypa commented 1 year ago

I don't understand why I'm not getting notifications when you comment… I keep having to remember to go in and check. I don't get emails I don't get notifications on my phone.