Closed zgypa closed 1 year ago
@tttomat19 : you can copy and paste the work you listed in the upwork messages. That list of things you did was great.
Some cleanup summary
use maven release plugin instead of python bumpversion. just a conventional way for maven.
use maven wrapper. portable and conventional for modern java/maven development.
update build instructions with maven wrapper. use package phase and assembly is in plugin execution goals.
flatten projects, remove empty ui project
move assembly plugin to tool jar only.
maven
shorten the name of the assembled tool jar. update readme with new shortened name.
attach source and javadoc for core library are bound to the "release" profile for maven
dcm4ceph-site is cleaned from templated text, meaningful texts are left as is.
no braced ifs are fixed to braced ifs (infamous apple ssl bug)
fixed all the javadoc errors (javadoc jar bound to release profile)
tested to build with java 17 and then run with java 8
tested to build with java 8 and then run with java 17
Configure Maven to properly deploy a JAR file into a dist folder
The question still up:
What to do with rsync target in Makefile? Is it needed?
Annihilate it. We have a ticket to deploy on Github resources. And correct me if i'm wrong, but at this point there is nothing left in Makefile
and you can proceed to delete the entire file.
Added some more structural cleanups, mainly with exception propagation up to the main() func. (Fail-fast style for exceptions.) More description could be found in commit messages. Now for the default scenario exceptions are handled either in main, or to set defaults.
Ok. I merged. Thanks!