open-ortho / dcm4ceph

Convert Cephalograms from JPEG to DICOM.
MIT License
0 stars 2 forks source link

Clean up Code and remove unnecesary structure #8

Closed zgypa closed 1 year ago

zgypa commented 1 year ago
zgypa commented 1 year ago

@tttomat19 : you can copy and paste the work you listed in the upwork messages. That list of things you did was great.

tttomat19 commented 1 year ago

Some cleanup summary

tttomat19 commented 1 year ago

The question still up:

What to do with rsync target in Makefile? Is it needed?

zgypa commented 1 year ago

Annihilate it. We have a ticket to deploy on Github resources. And correct me if i'm wrong, but at this point there is nothing left in Makefile and you can proceed to delete the entire file.

tttomat19 commented 1 year ago

Added some more structural cleanups, mainly with exception propagation up to the main() func. (Fail-fast style for exceptions.) More description could be found in commit messages. Now for the default scenario exceptions are handled either in main, or to set defaults.

zgypa commented 1 year ago

Ok. I merged. Thanks!