Loss of routing for neurons passing through spinal housing lyphs after minor tweak to housing lyph TOO Map region assignment

[bdebono]

I noticed that, neuron prostate/11, which is correctly laid out in...

https://apinatomy.dev.metacell.us/?demoUrl=https://raw.githubusercontent.com/open-physiology/open-physiology-viewer/feature/83_toggle/test/data/prostate.xlsx

...loses the correct neuronal spinal segment routing simply by moving the final housing lyph (major pelvic ganglion) from TOO Map region n2N to n2G.

I captured this behaviour in this video screengrab: https://youtu.be/xVZnkef9eno

[albatros13]

This is the manifestation of the same issue as in #289. When we switch among Codathon neurons, they at first are displayed incorrectly but dashed links are quickly rerouted and the view is fixed, it takes a split of a second. However, when one modifies the model not in a significant way, e.g., updating the scaffold region like Bernard did, the layout is not corrected and remains as shown in the video (same issue with prostate13 in #289 as ther model is essentially the same as in Codathon file). Can it be some kind of bug where the part of the layout algorithm is not activated on model load and only works with the default model?

[ddelpiano]

hi Natallia,

On the spot I don't have an answer for this, would you like us to allocate some of the remaining hours left to work on this?

Thanks, Dario

On Fri, 15 Sept 2023 at 19:43, Natallia @.***> wrote:

This is the manifestation of the same issue as in #289 https://github.com/open-physiology/open-physiology-viewer/issues/289. When we switch among Codathon neurons, they at first are displayed incorrectly but dashed links are quickly rerouted and the view is fixed, it takes a split of a second. However, when one modifies the model not in a significant way, e.g., updating the scaffold region like Bernard did, the layout is not corrected and remains as shown in the video (same issue with prostate13 in #289 https://github.com/open-physiology/open-physiology-viewer/issues/289 as ther model is essentially the same as in Codathon file). Can it be some kind of bug where the part of the layout algorithm is not activated on model load and only works with the default model?

— Reply to this email directly, view it on GitHub https://github.com/open-physiology/open-physiology-viewer/issues/290#issuecomment-1721632589, or unsubscribe https://github.com/notifications/unsubscribe-auth/AI7VD4MNK6HAWXPAGSDQYETX2SHVFANCNFSM6AAAAAA4Z6H3DY . You are receiving this because you were assigned.Message ID: @.***>

--

Dario Del Piano https://www.linkedin.com/in/dario-del-piano-a8a12937/ MetaCell, LLC / LTD http://metacell.us/ / @MetaCell https://twitter.com/MetaCell

[bdebono]

Hi Dario,

Let's agree to allocate time to address the following:

1. Investigate and fix any Neuroview-related issues currently open on Github (most significantly, #290 loss of routing for neurons passing through housing lyphs);
2. Make sure that disabled Neuroview has no side effects on the default layout.

What timeline do you envisage?

All the best,

Bernard

On Wed, 27 Sept 2023 at 07:18, Dario @.***> wrote:

hi Natallia,

On the spot I don't have an answer for this, would you like us to allocate some of the remaining hours left to work on this?

Thanks, Dario

On Fri, 15 Sept 2023 at 19:43, Natallia @.***> wrote:

This is the manifestation of the same issue as in #289 https://github.com/open-physiology/open-physiology-viewer/issues/289. When we switch among Codathon neurons, they at first are displayed incorrectly but dashed links are quickly rerouted and the view is fixed, it takes a split of a second. However, when one modifies the model not in a significant way, e.g., updating the scaffold region like Bernard did, the layout is not corrected and remains as shown in the video (same issue with prostate13 in #289 https://github.com/open-physiology/open-physiology-viewer/issues/289 as ther model is essentially the same as in Codathon file). Can it be some kind of bug where the part of the layout algorithm is not activated on model load and only works with the default model?

— Reply to this email directly, view it on GitHub < https://github.com/open-physiology/open-physiology-viewer/issues/290#issuecomment-1721632589>,

or unsubscribe < https://github.com/notifications/unsubscribe-auth/AI7VD4MNK6HAWXPAGSDQYETX2SHVFANCNFSM6AAAAAA4Z6H3DY>

. You are receiving this because you were assigned.Message ID: @.***>

--

Dario Del Piano https://www.linkedin.com/in/dario-del-piano-a8a12937/ MetaCell, LLC / LTD http://metacell.us/ / @MetaCell https://twitter.com/MetaCell

— Reply to this email directly, view it on GitHub https://github.com/open-physiology/open-physiology-viewer/issues/290#issuecomment-1737198002, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGMRLHUXH2FEMKQJ5DP53DX4QDPXANCNFSM6AAAAAA4Z6H3DY . You are receiving this because you authored the thread.Message ID: @.***>

[albatros13]

The update of the region is not even necessary - the tool shows the correct view on load but shows this after reloading the same model (on file open) Hence the issue is likely to be that some layout method is only called on component initialization.