Add pre-commit hook for linting

open-plan-tool / gui

Energy Planning Application

Other

8 stars 4 forks source link

Add pre-commit hook for linting #215

Open 4lm opened 1 year ago

4lm commented 1 year ago

[x] add pre-commit hook
[x] exclude certain files, e.g. auto-generated migration files
[x] homogenize CI workflow with pre-commit hook

4lm commented 1 year ago

Context: I'm running into issues, where I push stuff and the linter rejects it remote, linting should IMO happen also locally before commiting via a pre-commit hook.

Bachibouzouk commented 1 year ago

This is not an issue that the linter fails, it has lowest prio over features (especially because changing package now will lead to having to spend time making sure the online tool works well and I don't have that time until the workshop), you will have to live with the uncomfortable feeling of seeing test failing on CI ^^

I will nevertheless merge those changes after the stakeholder workshop

4lm commented 1 year ago

This is not an issue that the linter fails, it has lowest prio over features (especially because changing package now will lead to having to spend time making sure the online tool works well and I don't have that time until the workshop),

OK, thanks for the insides!

you will have to live with the uncomfortable feeling of seeing test failing on CI ^^

Ok, I can live with failing linter + failing unit tests

I will nevertheless merge those changes after the stakeholder workshop

Ok, sounds good!