open-plan-tool / gui

Energy Planning Application
Other
8 stars 4 forks source link

Bug list #238

Open c-moeller opened 1 year ago

c-moeller commented 1 year ago

Dear PF, here comes a list with the bugs we found in our first two training sessions and which we think should have priority. We might add some more. Let's talk about it (with @FredericHirschmueller and/or @c-moeller) when you are back, but you could start already before talking.

Bachibouzouk commented 1 year ago

I classified them into categories and will try to solve as many as possible with the same PR

General GUI

Results

Component input malfunction

Server

Bachibouzouk commented 1 year ago
  • Laden der Seite und Simulation dauerte in Schulung sehr lange

I could try to increase the number of workers on the server. @c-moeller , @FredericHirschmueller it is good to tell the people in the workshops that the tool hosted on RLI server is there mostly for demonstration purposes (i.e. we are not liable to provide the tool to everyone with super high speed) and if they want more speed/data security they can perfectly setup their own server or work with the tool locally

Bachibouzouk commented 1 year ago
  • Bug, wenn Einspeisevergütung größer als LCOE von Windkraftanlage --> maximale Kapazität --> als Pflicht machen und besserer Beschreibungstext

@FredericHirschmueller @c-moeller - do you remember what you meant by this?

Bachibouzouk commented 1 year ago
  • Feste Projektkosten zweimal (in Projekt und Komponente) --> nur einmal im Projekt

This one is only a mislabel, the fix costs in project are on top of the whole simulation, whereas the fix costs for the asset might be a fix fee one has to pay like delivery, ie. regardless how many units it costs 5000 to deliver, or one need to pay a fixed land tax to be able to build on it etc ...

I propose to just relabel it "Fixed costs"

Bachibouzouk commented 1 year ago

@c-moeller

This is the text which explains what is done with the data for the GUI platform

The data you upload when using our online platform (https://open-plan.rl-institut.de/) is only accessible by you or the other user(s) you decide to share a project with as well as the IT administrators of the database. The IT administrators of the database will not access directly user data unless asked by a user or granted with a user's explicit permission. The IT administrators of the database reserve the right to collect indirect user data by performing filter operations on the database (for example a lookup of how many user are using an instance of a specific component for statistic purposes or sending targeted warning messages via the online application to those users if a bug/malfunction of this component has been reported). The user data (user data as well as all projects or scenarios data) will not be shared with any third party organization without the user's explicit consent.

This is the text which explains what is done with the data for the simulation platform: The simulation server used by https://open-plan.rl-institut.de/ is located at https://mvs-open-plan.rl-institut.de/, the data needed to run a simulation there are available via a public link in case the simulation fails (in that case the input data is visible to the person visiting the link, this is intended for debug purposes). The link is valid for 24 hours after the simulation has been successful or has failed. In case of simulation success, only the simulation results are available upon visit of the link. As the link is created automatically with a randomly generated token and only last 24 hours and the user data are not communicated to the simulation server, the likelihood of data privacy breach is quite small and was considered acceptable.

Bachibouzouk commented 1 year ago
  • [ ] exclamationEs gibt keine Einspeisegrenze ins Netz, oder? Warum ist Einspeisung gekappt? --> Peak demand pricing ist irgendwie noch mit Einspeisung verknüpft. Das sollte nicht so sein --> mit Markus oder Caro besprechen (Nutzungsfall Schulung)

I think it was a concerted decision that the peak demand pricing should be split between consumption and feedin, this is why feedin is affected by peak demand pricing. If one assigns all the costs of peak demand pricing to the consumption then feedin is "freed" from the Peak demand price value. What should we do here @c-moeller, @mstich0, @FredericHirschmueller ?

mstich0 commented 1 year ago
  • [ ] exclamationEs gibt keine Einspeisegrenze ins Netz, oder? Warum ist Einspeisung gekappt? --> Peak demand pricing ist irgendwie noch mit Einspeisung verknüpft. Das sollte nicht so sein --> mit Markus oder Caro besprechen (Nutzungsfall Schulung)

I think it was a concerted decision that the peak demand pricing should be split between consumption and feedin, this is why feedin is affected by peak demand pricing. If one assigns all the costs of peak demand pricing to the consumption then feedin is "freed" from the Peak demand price value. What should we do here @c-moeller, @mstich0, @FredericHirschmueller ?

hi PF, probably this was due to my suggestion, but it was a bad one. We should apply the peak price only on the demand (100%) and cancel it for the feed-in. This is the standard for grid fees in germany.

mstich0 commented 1 year ago
  • Bug, wenn Einspeisevergütung größer als LCOE von Windkraftanlage --> maximale Kapazität --> als Pflicht machen und besserer Beschreibungstext

@FredericHirschmueller @c-moeller - do you remember what you meant by this?

reason for this is to stop simulation errors because of unbound solutions (e.g. infinite Windpower capacity) I would suggest that we implement a hidden standard value for any maximum capacity (that c´will be overwritten if manual input is done) somewhere at 9,999.999,999 so it doesnt give simulation errors anymore

Bachibouzouk commented 1 year ago

hi PF, probably this was due to my suggestion, but it was a bad one. We should apply the peak price only on the demand (100%) and cancel it for the feed-in. This is the standard for grid fees in germany.

This is now reversed :) the feedin should not depend anymore of the peak demand pricing. Could you tell me if you observe that too in the scenarios where you noticed it @FredericHirschmueller ?