search

open-policy-agent / frameworks

Apache License 2.0
119 stars 51 forks source link

Remove the notion of "Enforcement Action" from the engine interface #298

Open maxsmythe opened 1 year ago

maxsmythe commented 1 year ago

Currently, Engine is responsible for returning an enforcement action. This was originally intended to allow for the possibility of dynamic enforcement actions, but that would be incompatible with the capabilities of the CEL KEP. As such, it should be removed.

https://github.com/open-policy-agent/frameworks/blob/9f70a3e5e75db72a81c79c26dd358feb027ddcf5/constraint/pkg/client/drivers/to_result.go#L82-L90

ritazh commented 1 year ago

What kind of impact/issue does removing "Enforcement Action" present? Will there be any backward compatibility issues?

maxsmythe commented 1 year ago

No user-facing backwards compatibility issues... we never piped this through to users. Anyone who has written a driver may be affected, but I'm not aware of anyone whose done that (and that part of the CF is alpha).