open-policy-agent / frameworks

Apache License 2.0
119 stars 52 forks source link

feat: remove cel driver from framework #486

Closed abhipatnala closed 3 weeks ago

maxsmythe commented 1 month ago

LGTM, pending approval of the Gatekeeper PR (modulo import override) so that the code moved to G8r can be merged as a fast-follow.

codecov-commenter commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 53.42%. Comparing base (76869f8) to head (6b8322d). Report is 40 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #486 +/- ## ========================================== - Coverage 54.68% 53.42% -1.26% ========================================== Files 71 97 +26 Lines 5241 6115 +874 ========================================== + Hits 2866 3267 +401 - Misses 2073 2513 +440 - Partials 302 335 +33 ``` | [Flag](https://app.codecov.io/gh/open-policy-agent/frameworks/pull/486/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-policy-agent) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/open-policy-agent/frameworks/pull/486/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-policy-agent) | `53.42% <ø> (-1.26%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-policy-agent#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

maxsmythe commented 3 weeks ago

Waiting on https://github.com/open-policy-agent/gatekeeper/pull/3570 approval to merge

ritazh commented 3 weeks ago

@maxsmythe does this PR LGTY? we need this PR to merge first so go.mod in https://github.com/open-policy-agent/gatekeeper/pull/3570 can point to the latest commit