search

open-power / HTX

Apache License 2.0
14 stars 19 forks source link

Fix a few compiler warnings #153

Closed antonblanchard closed 5 years ago

antonblanchard commented 5 years ago

Signed-off-by: Anton Blanchard anton@ozlabs.org

vishnupriya-r99 commented 5 years ago

Hello Anton, Thanks for contributing to HTX and pointing to us the overlooked warnings. We are unable to accept this pull request due to the following reasons: htxd_shutdown_flag is a global variable which is used widely, is treated as an entity by itself. If I add it to the header file mentioned in the pull req., lot of other unnecessary inclusions of other headers would be required. Right now, we don't have a htxd_time_driven_run_monitor.h. I'll take care of the declarations without creating one. I might have to use htxd_time_driven_run_monitor_ecg() in other contexts also, so not making it static at the moment. Another pull req. will be submitted to include the changes in a different manner for the same. (#154)