open-power / HTX

Apache License 2.0
14 stars 19 forks source link

Adding hours to get_run_time output #159

Closed narasimhan-v closed 4 years ago

narasimhan-v commented 4 years ago

Adding hours to get_run_time output, which is just minutes and seconds as of now.

Signed-off-by: Narasimhan V sim@linux.vnet.ibm.com

avinashkuttan commented 4 years ago

This code change causes the command output format change. The command output change may causes failure of the existing test automation, since the automation scripts process the HTX command output. So, the existing command output format change requires automation update also. Since this is not a critical change, the code update is avoiding now.

narasimhan-v commented 4 years ago

@avinashkuttan Is there too much dependency on the output format ? The reason I wanted this change is, when we run HTX for more than couple of hours (for days together sometimes) it is difficult to interpret only minutes. It helps if the output is in hours. Going by the same logic, output in terms of days would be even better.

narasimhan-v commented 4 years ago

@avinashkuttan Please let me know, if the automated tests are part of HTX, I can change them also.

Also, there is a fixup of this code change, which I will do if you are fine with accepting it.

avinashkuttan commented 4 years ago

@narasimhan-v Different labs use the HTX command line interface for their test automation. We do not have access to the automation scripts. If we make any command output change, that may affect the existing automation. So we avoid the output format change as much as possible. In this case, since the time value is available in minutes, you can converts at your end to the required format and use it.

narasimhan-v commented 4 years ago

@avinashkuttan okay, thanks.