search

open-power / hostboot

System initialization firmware for Power systems
Apache License 2.0
74 stars 97 forks source link

fix chip unit mask error for nmmu1 PartialGoodRule #212

Closed lili-lilili closed 1 year ago

dcrowell77 commented 1 year ago

Good catch, we'll take a look and get the change in.

dcrowell77 commented 1 year ago

I'm curious, how did you discover this bug? As far as I'm aware, there are no shipping parts with the NMMU1 marked as bad.

lili-lilili commented 1 year ago

I'm curious, how did you discover this bug? As far as I'm aware, there are no shipping parts with the NMMU1 marked as bad.

We are testing opal on the rainier. When we test ioSCM cpu, the nmmu1 config always report error. I want to confirm if nmmu1 is being discovered and initialized correct. So I check the PG keyword in the mvpd and the PG rule for the nmmu1, then the problem is found.

Now I know the nmmu1 is deconfiged, but this is still a problem to opal. Because Hostboot does not pass the functional status of nmmu to OPAL, OPAL does not know which nmmu is available. Can you give me some advice?

dcrowell77 commented 1 year ago

Full opencapi support is one of the features that hasn't been done in our P10 product code so I'm not surprised there are still some holes. At a high level, the way it should be working is that the SMP Link Entry Information area of HDAT should be filled in with accurate data for the links that are currently active. OPAL would then consume that data to decide which links to train.

Note that there is currently nothing in IBM's plans to implement this support.

lili-lilili commented 1 year ago

Full opencapi support is one of the features that hasn't been done in our P10 product code so I'm not surprised there are still some holes. At a high level, the way it should be working is that the SMP Link Entry Information area of HDAT should be filled in with accurate data for the links that are currently active. OPAL would then consume that data to decide which links to train.

Note that there is currently nothing in IBM's plans to implement this support.

I think we can do this job;. I will create another pull request. I hope you can help to check and merge the request.

dcrowell77 commented 1 year ago

Sounds great. This current PR is just going through the internal testing/review process, it should be in soon.