search

open-power / hostboot

System initialization firmware for Power systems
Apache License 2.0
75 stars 97 forks source link

Support get SMS string from fru vpd #218

Closed lili-lilili closed 1 year ago

lili-lilili commented 1 year ago

Add support for UTIL::F5 and UTIL::F6 Hostboot will get F5 and F6 from BMC through PLDM and cache it to the PVPD. Finally,F5 and F6 will be merged together and write to hdat system ipl parameter.

lili-lilili commented 1 year ago

Thanks，Dan and Nick; Because of serious network problems, I can't reply to you smoothly。 I have modified the source code, and push it to the repository.

dcrowell77 commented 1 year ago

Please resolve the merge conflicts on top of the master-p10 branch.

lili-lilili commented 1 year ago

The conflicts has been resolved; In order to ensure the rigor of the code, we performed a function test before pushing. It took a little time.

dcrowell77 commented 1 year ago

This change failed our internal CI. The error makes me think there might be a prereq on some BMC changes to give us the record back.

372.95136|================================================ 372.95767|Error reported by vpd (0x1D00) EID 0x9000003F 373.96399| The requested record was not found in the VPD VTOC. 373.96402| ModuleId 0x30 VPD::VPD_IPVPD_FIND_RECORD_OFFSET_SEEPROM 374.98391| ReasonCode 0x1d03 VPD::VPD_RECORD_NOT_FOUND 374.98394| UserData1 Requested Record : 0x000000040000002b 374.98397| UserData2 Requested Keyword : 0x0000000000020000 374.98399|------------------------------------------------ 374.98401| Callout type : Hardware Callout 376.00178| Target : Physical:/Sys0/Node0 376.00180| Deconfig State : DECONFIG 376.00182| GARD Error Type : GARD_NULL 376.00185| Priority : SRCI_PRIORITY_HIGH 376.00187|------------------------------------------------ 376.00190| Callout type : Procedure Callout 376.00192| Procedure : EPUB_PRC_HB_CODE 376.00195| Priority : SRCI_PRIORITY_LOW 376.00197|------------------------------------------------ 376.00207| Hostboot Build ID: hostboot-p10-site_local-hostboot-branched-fw1030-418-gaf6bbb6-sha1:72323fe9/hbicore.bin 376.00209|================================================

Were you using an updated/patched BMC level when you verified it locally?

lili-lilili commented 1 year ago

Yes, BMC need to include this commit: https://github.com/ibm-openbmc/pldm/pull/350

lili-lilili commented 1 year ago

I did a test, and can reproduce the same problem.

dcrowell77 commented 1 year ago

I've heard this is now working. Is there an updated set of code to review?

lili-lilili commented 1 year ago

I've heard this is now working. Is there an updated set of code to review?

There is no update. It the crc checksum for lid caused that error.