open-power / op-build

Buildroot overlay for Open Power
GNU General Public License v2.0
103 stars 183 forks source link

Skiroot dependencies for Secure & Trusted Boot #2915

Open sammj opened 5 years ago

sammj commented 5 years ago

Incoming changes for Secure & Trusted Boot on OpenPOWER platforms will have a few dependencies in the Skiroot image. This may apparently include efivar and utilities from efitools.

There may be some porting work to be done here which the STB team will handle. More generally this will probably push up hard against the 16MB size limit for BOOTKERNEL or blow right past it. The STB team will need to work with upstream op-build to work out

Possibly we'll have to look into increasing BOOTKERNEL size or potentially packing some tools as pb-plugins if possible.

naynajain commented 5 years ago

We would want to submit the op-build patch for efivar asap, however we might have to do some changes to it in context of POWER. This might take us some time. But as Sam mentioned that it can push hard against the size limit. To get the confirmation on the size issue at the earliest, is it ok if we send the op-build patch now itself ? We will keep working on our POWER changes parallely and share the update once that is done.

I would like to get the feedback that if the suggested approach looks fine, or is there a better way ?

Thanks & Regards,

sammj commented 5 years ago

Sending through a patch now is the best way :) Then it can run through the pull-request CI and we can see how it handles it.

naynajain commented 5 years ago

Thanks Sam !! We will try to send the patch asap.

Thanks & Regards,

naynajain commented 5 years ago

Eric had tried building efivar into skiroot image. It seems it adds additional 300kb approximately.. He tested it and there was no complain on the size. Also, it seems efivar is already available from buildroot. It just needs to be enabled via an openpower config - BR2_PACKAGE_EFIVAR=y. To try it now, we did via "op-build menuconfig". We are not very sure which config is the right one to be edited for the patch submission. Will it be openpower/configs/witherspoon_defconfig ?

ghost commented 5 years ago

Hemant Baxi notifications@github.com writes:

Eric had tried building efivar into skiroot image. It seems it adds additional 300kb approximately.. He tested it and there was no complain on the size. Also, it seems efivar is already available from buildroot. It just needs to be enabled via an openpower config - BR2_PACKAGE_EFIVAR=y. To try it now, we did via "op-build menuconfig". We are not very sure which config is the right one to be edited for the patch submission. Will it be openpower/configs/witherspoon_defconfig ?

All platforms that will support secure boot, which means all POWER9 ones.

-- Stewart Smith OPAL Architect, IBM.