search

open-power / pdbg

PowerPC FSI Debugger
Apache License 2.0
16 stars 39 forks source link

Export enter and continue MPIPL chip-ops #47

Closed dhruvibm closed 4 years ago

amitay commented 4 years ago

I would prefer the public api for mpipl to have sbe_ prefix. These hardware procedures are likely to be only implemented via sbe.

amitay commented 4 years ago

Also, the api will expect a pib target and not sbe target. Please update documentation accordingly.

amitay commented 4 years ago

Please split the patch into two. One to add hw procedure to sbefifo and the second one which adds public api in libpdbg. Also, in documentation you need to define what the return value is.

dhruvibm commented 4 years ago

Hi made two commits based on the comment and added the return documentation.