search

open-power / pdbg

PowerPC FSI Debugger
Apache License 2.0
17 stars 39 forks source link

libpdbg_sbe: fix SBE state api's assert #58

Closed ojayanth closed 2 years ago

ojayanth commented 3 years ago

This commit is to fix below assert initiated by SBE state apis' ../git/libpdbg/libpdbg.c:265: require_target_parent: Assertion `parent' failed

SBE state api function input target is pib andin the api implementaion is trying to get fsi target using pdbg_target_require_parent(). This seems to be wrong because PIB and FSI got same hierarchy under processor pdbg target.

Proposed fix is get parent processor target from the PIB and then get associated fsi child target.

amitay commented 2 years ago

This is not correct. FSI target is the parent of PIB target for both BMC kernel and sbefifo backends. The problem is with pdbg_target_require_parent() function, which searches only the system tree.

amitay commented 2 years ago

I have pushed the correct fix upstream.