search

open-power / pdbg

PowerPC FSI Debugger
Apache License 2.0
17 stars 39 forks source link

Add PMIC, ADC, and GPIO Expander targets #63

Closed RameshIyyar closed 2 years ago

amitay commented 2 years ago

You cannot add generic i2c devices anywhere in the system tree. If you want to use access them via i2c bus, then there needs to be a right i2c bus with driver before you can start adding i2c devices.

RameshIyyar commented 2 years ago

You cannot add generic i2c devices anywhere in the system tree. If you want to use access them via i2c bus, then there needs to be a right i2c bus with driver before you can start adding i2c devices.

As we discussed changed the pdbg class name as per MRW target id i.e ADC and GPIO Expander

amitay commented 2 years ago

Are all the targets at the same level as DIMM target in P10 device tree?

All the patches require fixing spaces to tabs.

RameshIyyar commented 2 years ago

Are all the targets at the same level as DIMM target in P10 device tree?

No, All these targets are placed under OCMB like MEM_PORT.

All the patches require fixing spaces to tabs.

Sure, will fix it

RameshIyyar commented 2 years ago

@amitay @ojayanth addressed the comments, please take a look

amitay commented 2 years ago

Merged.