search

open-power / petitboot

GNU General Public License v2.0
205 stars 56 forks source link

discover/grub2: Ignore bare values in blscfg files #107

Closed rarbab closed 4 months ago

rarbab commented 5 months ago

Fix for a bug found recently, when a boot source was upgraded from Fedora CoreOS 38 to 39. The new bootloader config (inadvertently) contained a bare value:

grub_users ""
jk-ozlabs commented 5 months ago

Looks good, but probably worth adding a testcase too?

sudeeshjohn commented 5 months ago

Tested this patch on a Witherspoon(8335-GTH), and works fine.

rarbab commented 4 months ago

Looks good, but probably worth adding a testcase too?

No problem! Added.

jk-ozlabs commented 4 months ago

I've merged this locally, all testing fine here at present. Will push up when I have some feedback on other pending PRs, and cut a release from that.