Port is dropped during discovery if DHCP option 210 is a URL

open-power / petitboot

GNU General Public License v2.0

214 stars 56 forks source link

Port is dropped during discovery if DHCP option 210 is a URL #54

Closed sammj closed 5 years ago

sammj commented 5 years ago

If option 210 (prepathprefix) is a valid URL with a port specified the port is missing when Petitboot uses that URL for discovery, eg:

[00:43:13] user_event_process: 139 bytes
[00:43:13] user_event dhcp event:
[00:43:13]      device: enP4p1s0f1
[00:43:13]      pxepathprefix => http://fs.ozlabs.ibm.com:80/~sam/
...
[00:43:13] Running command:
 exe:  /usr/bin/wget
 argv: '/usr/bin/wget' '-O' '/tmp/pb-CmMbP3' '--quiet' 'http://fs.ozlabs.ibm.com/~sam/pxelinux.cfg/01-98-be-94-83-00-97

sammj commented 5 years ago

Fixed by http://patchwork.ozlabs.org/patch/1026381/, where pb_url_to_string() forgot about the port.

sammj commented 5 years ago

Which is merged as https://github.com/open-power/petitboot/commit/28d0d7035ee3099935ef264db40a86142c098ec5