open-power / petitboot

GNU General Public License v2.0
205 stars 56 forks source link

Several fixes and a few backports for Petitboot 1.7.x #67

Closed klauskiwi closed 4 years ago

klauskiwi commented 4 years ago

A number of fixes, and some arguably additions, to Petitboot stable branch 1.7.x

Brandon Bergren (1): Fix pb-discover segfaults caused by list corruption.

Brett Grandbois (3): discover/grub: Add cmdline signature support for BLS entries lib/file: remove mkstemp umask in copy_file_secure_dest discover/boot: abort kexec on any error from validation

Geoff Levand (1): lib/talloc: Fix TALLOC_ABORT

Javier Martinez Canillas (10): discover/grub: Add blscfg command support to parse BootLoaderSpec files discover/grub: Allow to choose a different BLS directory discover/grub: Reverse BLS entries sorting to match Petitboot's boot order discover/grub: Don't add discover context boot options in blscfg handler discover/grub: Allow to set a default index for BLS entries test/parser: Make parser_scandir() ignore files with path len less than dir discover/grub: Use different paths to search for the BLS directory discover/grub: Improve BLS grub environment variables expansion discover/grub2: Allow using title for default even if id was defined discover/grub2: Allow to separate the --id argument using a space char

Jeremy Kerr (14): discover/grub2: 'search' set-variable defaults to root discover/grub2: Use getopt for search argument parsing discover/grub2: test for (ignored) --no-floppy argument discover/grub2: Add support for UUID and label for 'search' command discover/grub2: expose a struct for grub2 file references discover/grub2: Add parsing code for grub2 file specifiers discover/grub2: add support for grub2-style path specifiers in resources discover/grub2: Allow (device)/path references in general script usage discover/grub2: Add a reference from script to parser discover/grub2: expose internal parse function discover/grub2: make statements_execute non-static discover/grub2: implement 'source' command test/parser: Add test for recent RHCOS grub2 config test/parser: Add RHEL8 grub config test

Samuel Mendoza-Jonas (10): discover/pxe-parser: Avoid potential null dereference lib/file: Avoid off-by-one error in array lib/security: Fix broken if statements in gpg_validate_boot_files() discover: Rescan SCSI devices on reinit discover/udev: Don't require ID_NET_NAME_PATH property discover/user-event: Check for required parameters discover/boot: Fix talloc parent for resource URLs discover: Display warning if saving config fails utils/pb-console: Ignore SIGINT utils: Quote plugin name and vendor variables

klauskiwi commented 4 years ago

Make check is all-green (see below), but I had to add edcc7dc since it was trying to parse the directory entry name itself and failing. I'll try to do some more testing on a Boston / P9DSU system (see discussion in https://github.com/open-power/op-build/pull/3355) and report back

---
============================================================================
Testsuite summary for petitboot 20191223.g7b4d036f
============================================================================
# TOTAL: 105
# PASS:  105
# SKIP:  0
# XFAIL: 0
# FAIL:  0
# XPASS: 0
# ERROR: 0
============================================================================