open-power / serverwiz

Apache License 2.0
4 stars 18 forks source link

Cannot read any XML files #24

Closed ghost closed 8 years ago

ghost commented 8 years ago

With any XML file available on github, I get "ServerWiz cannot read this version of XML" error.

screenshot from 2016-09-09 13-20-28

ghost commented 8 years ago
01:22:50.081 - [INFO] - Reading XML: /home/stewart/garrison-xml/garrison.xml
01:22:50.082 - [WARNING] - No parts loaded
01:22:50.098 - [SEVERE] - ServerWiz cannot read this version of XML: /home/stewart/garrison-xml/garrison.xml
ghost commented 8 years ago

and then, once I click okay:

01:23:06.539 - [INFO] - Attribute dropped: WOF_ENABLED from sys-0
01:23:06.539 - [INFO] - Attribute dropped: WOF_PROC_SORT from sys-0
01:23:06.539 - [INFO] - Attribute dropped: WOF_FREQUENCY_UPLIFT from sys-0
01:23:06.539 - [INFO] - Attribute dropped: WOF_REGULATOR_EFFICIENCIES from sys-0
01:23:06.545 - [INFO] - Attribute dropped: LOCATION_CODE from proc
01:23:06.545 - [INFO] - Attribute dropped: NPU_MMIO_BAR_ENABLE from proc
01:23:06.545 - [INFO] - Attribute dropped: NPU_MMIO_BAR_BASE_ADDR from proc
01:23:06.545 - [INFO] - Attribute dropped: NPU_MMIO_BAR_SIZE from proc
01:23:06.554 - [INFO] - Attribute dropped: LOCATION_CODE from membuf-0
01:23:06.557 - [INFO] - Attribute dropped: LOCATION_CODE from spd
01:23:06.559 - [INFO] - Attribute dropped: LOCATION_CODE from vddr_vreg-0
01:23:06.566 - [INFO] - Attribute dropped: LOCATION_CODE from membuf_vpd-1
01:23:06.567 - [INFO] - Attribute dropped: LOCATION_CODE from vddr_gpio-1
01:23:06.570 - [INFO] - Attribute dropped: LOCATION_CODE from PEX8718-0
01:23:06.571 - [INFO] - Attribute dropped: LOCATION_CODE from bmc-0
01:23:06.572 - [INFO] - Attribute dropped: LOCATION_CODE from planar_vpd-1
01:23:06.572 - [INFO] - Attribute dropped: LOCATION_CODE from apss-0
01:23:06.574 - [INFO] - Attribute dropped: LOCATION_CODE from vddr_gpio-0
01:23:06.574 - [INFO] - Attribute dropped: LOCATION_CODE from birchvpd-0
01:23:06.574 - [INFO] - Attribute dropped: LOCATION_CODE from membuf_vpd-0
01:23:06.574 - [INFO] - Attribute dropped: LOCATION_CODE from planar_vpd-0
01:23:06.575 - [INFO] - Loaded XML in 16492 milliseconds
01:23:06.579 - [SEVERE] - Invalid Child target id: psuconn-1
01:23:06.579 - [SEVERE] - Invalid Child target id: gpu-0
01:23:06.580 - [SEVERE] - Invalid Child target id: gpu-1
01:23:06.580 - [SEVERE] - Invalid Child target id: gpu-2
01:23:06.580 - [SEVERE] - Invalid Child target id: gpu-3
nkskjames commented 8 years ago

I had to change to the format slightly for the master branch of serverwiz because of the expanded use cases and for performance reasons. The P8 system xml is currently supported in the master-p8 branch. I'm working on making master backwards compatible. I have a converter, but need to update hostboot translator to support both formats before releasing. The only change in the format is there are outer tags surrounding main groups of data.

ghost commented 8 years ago

Ahhh... unfortunately, master-p8 doesn't build:

[stewart@birb serverwiz]$ ant -f build.xml clean compile jar
Buildfile: /home/stewart/serverwiz/build.xml

clean:
   [delete] Deleting directory /home/stewart/serverwiz/build

compile:
    [mkdir] Created dir: /home/stewart/serverwiz/build/classes
    [javac] /home/stewart/serverwiz/build.xml:17: warning: 'includeantruntime' was not set, defaulting to build.sysclasspath=last; set to false for repeatable builds
    [javac] Compiling 31 source files to /home/stewart/serverwiz/build/classes

BUILD FAILED
/home/stewart/serverwiz/build.xml:17: /home/stewart/serverwiz/C:/eclipse/plugins does not exist.

Total time: 0 seconds

I tried to bisect it back in master and hit this too. It may be easier to just make master be able to read both.

nkskjames commented 8 years ago

This is fixed with 5ed0ce8078d654d899f0e2134459faebb3217105.

ghost commented 8 years ago

Thanks, that works!

Any plan to update all our XML files to the new format?

nkskjames commented 8 years ago

Yes. Step 1, waiting on hostboot side code change to be reviewed and integrated. Step 2, someone handcoded a few things outside of serverwiz in garrison.xml and reused the unique ID of the venice for naples so, hostboot is ok, because the [system].xml is self contained, but serverwiz messes it up because of duplicate ID of another part in the parts library. I'll get it fixed though.

ghost commented 8 years ago

nkskjames notifications@github.com writes:

Yes. Step 1, waiting on hostboot side code change to be reviewed and integrated. Step 2, someone handcoded a few things outside of serverwiz in garrison.xml and reused the unique ID of the venice for naples so, hostboot is ok, because the [system].xml is self contained, but serverwiz messes it up because of duplicate ID of another part in the parts library. I'll get it fixed though.

I imagine the rate of (incompatible) change to the XML format should decrease over time, as updating an increasing number of platforms isn't going to be fun.

But since it's you that has to do it, I'm sure you're aware :)

Stewart Smith OPAL Architect, IBM.