search

open-power / serverwiz

Apache License 2.0
4 stars 18 forks source link

Targets.pm accesses non-existent attributes #33

Closed santoshpuranik closed 7 years ago

santoshpuranik commented 7 years ago

The buildAffinity() function in Targets.pm does this:

            $self->setAttribute($target, "FABRIC_GROUP_ID",
                  $self->getAttribute($socket,"FABRIC_GROUP_ID"));

FABRIC_GROUP_ID is defined under the chip-processor target. The above code tries to fetch it from a proc-socket target and set it into the chip target (and fails in the getAttribute). Is this a bug in the proc-socket target instance (i.e, the attribute needs to be added to it) or does the above code have to go?

santoshpuranik commented 7 years ago

@ruby452, could you comment?

pragupta commented 7 years ago

FABRIC_GROUP_ID should be defined under socket in the system.xml. Targets.pm copies this attribute from socket to proc target as hostboot doesn't have knowledge of the socket target and has two instances of the proc itself.

santoshpuranik commented 7 years ago

Thanks, @pragupta . @ruby452 is handling this with https://github.com/open-power/common-mrw-xml/pull/80.