search

open-power / skiboot

OPAL boot and runtime firmware for POWER
Apache License 2.0
100 stars 134 forks source link

6.2.x Fix build with gcc9 #248

Closed hramrach closed 3 years ago

hramrach commented 5 years ago

[ Upstream commit ef691db3533742d9dd6eed1a311472a7c52be94b ]

Only the reg member is sent anywhere (via xscom_write), so the structure does not need to be packed.

Fixes GCC9 build problem: hw/sbe-p9.c: In function ‘p9_sbe_msg_send’: hw/sbe-p9.c:270:9: error: taking address of packed member of ‘struct p9_sbe_msg’ may result in an unaligned pointer value [-Werror=address-of-packed-member] 270 | data = &msg->reg[0]; | ^~~~

Signed-off-by: Stewart Smith stewart@linux.ibm.com

Please do not submit a Pull Request via github. Our project makes use of mailing lists for patch submission and review. For more details please see https://open-power.github.io/skiboot/

hegdevasant commented 3 years ago

All are compilation fixes only. Are you still interested in getting these patches into v6.2.x stable tree?

-Vasant

hegdevasant commented 3 years ago

I think we are not interested in this branch anymore. Hence closing this PR.

-Vasant