search

open-quantum-safe / liboqs-go

Go bindings for liboqs
https://openquantumsafe.org/
MIT License
69 stars 24 forks source link

dockerbuild fails #21

Closed vsoftco closed 1 year ago

vsoftco commented 1 year ago

E.g., https://app.circleci.com/pipelines/github/open-quantum-safe/liboqs-go/67/workflows/ff6a4e56-dcca-40b8-819c-06e00fc85a4f/jobs/129

vsoftco commented 1 year ago

@baentsch any idea why?

baentsch commented 1 year ago

@baentsch any idea why?

Well yes: The error message:

lstat /root/project/docker/Dockerfile: no such file or directory

says the Dockerfile is no longer where it's expected by .circleci/config.yml:

https://github.com/open-quantum-safe/liboqs-go/blob/28be2ce91ace968370f3f04b38d2128b160396c0/.circleci/config.yml#L99

But once the github based code added in #20 runs OK you may simply want to remove the old docker build code completely from CircleCI. Sorry for not spotting this in review. See #22 for what I mean.

Please work with @SamYuan1990 to completely resolve this as I'm heading out to vacation in a few minutes. I'm sure @xvzcf could also help.

dstebila commented 1 year ago

@vsoftco would you have a chance to look at #22 and #23 to help move towards resolving this? Or should we roll #20 back?

vsoftco commented 1 year ago

@dstebila Will look at it shortly

baentsch commented 1 year ago

ping @vsoftco -- please let me know if I could/should do anything.

vsoftco commented 1 year ago

Thanks @baentsch !! I'll close it this week, very hectic on my side

baentsch commented 1 year ago

Was it intentional to remove docker build automation completely, @vsoftco ? This change was not part of any PR as far as I can see. I only coincidentally noticed this when testing/running the (pretty broken) docker image "openquantumsafe/python".

If so, I'd suggest closing this issue and removing https://hub.docker.com/repository/docker/openquantumsafe/python/general (well, any language-wrapper docker image, actually).

vsoftco commented 1 year ago

Decided to drop support for this, as it introduce additional dependencies that are difficult to maintain in the long term.