search

open-quantum-safe / liboqs-python

Python 3 bindings for liboqs
https://openquantumsafe.org/
MIT License
108 stars 39 forks source link

Initial commit of Python wrapper. #1

Closed christianpaquin closed 5 years ago

christianpaquin commented 5 years ago

Contains my proposed Python wrapper. @truth-quark, I'd appreciate your feedback.

dstebila commented 5 years ago

Cool!

christianpaquin commented 5 years ago

I haven't tested on Python 2; I got errors initially with sigs because the conversion from Python bytes to ctypes array added an extra 0 byte. First thing would be to check that the Python input/output variables are as expected. Thanks for the comments; I'll work on them next week, starting on Wednesday :)

christianpaquin commented 5 years ago

@truth-quark, I pushed an update addressing your comments. Some are outstanding; I replied so let me know what you think is best. I also added a basic unit test file, so you can take a look at that as well.

christianpaquin commented 5 years ago

@truth-quark, I pushed another commit addressing your latest comments. I also opened issue #2 and assigned it to you.

christianpaquin commented 5 years ago

Thanks for the review. I'll update the README in a separate PR.