search

open-quantum-safe / liboqs-python

Python 3 bindings for liboqs
https://openquantumsafe.org/
MIT License
108 stars 39 forks source link

Add OQS rand API support #19

Closed vsoftco closed 4 years ago

vsoftco commented 4 years ago

<oqs/rand> support

christianpaquin commented 4 years ago

I'll be able to review later this week or early next week.

vsoftco commented 4 years ago

@christianpaquin Fixes done, ready to release, thanks!

vsoftco commented 4 years ago

@christianpaquin How can I resolve the "requesting changes"?

christianpaquin commented 4 years ago

Ah, sorry @vsoftco, I thought we had to discuss the broader proposed API change of this PR on the OQS dev call before merging (should we expose the random API or not). @dstebila, did we reach a conclusion?

dstebila commented 4 years ago

Ah, sorry @vsoftco, I thought we had to discuss the broader proposed API change of this PR on the OQS dev call before merging (should we expose the random API or not). @dstebila, did we reach a conclusion?

I'm fine with exposing the rand API in Python, although as I comment in my review I don't think we need to expose the custom_algorithm function.

vsoftco commented 4 years ago

@dstebila @christianpaquin Let's chat about it during today's meeting. Indeed, we agreed to discuss during the meeting. I thought I have to do something on my side to "resolve the changes".