search

open-quantum-safe / liboqs-python

Python 3 bindings for liboqs
https://openquantumsafe.org/
MIT License
122 stars 45 forks source link

Fix Dockerfile build by sticking to Ubuntu 22.04 #90

Closed loganaden closed 3 months ago

baentsch commented 3 months ago

The dockerfile(s) (also) should serve as a canary if something goes haywire downstream, so fixing them to a specific version is not quite ideal. Better would be a functional update wherever necessary to allow current ubuntu versions to keep using OQS.

loganaden commented 3 months ago

@baentsch I can take a look ?

baentsch commented 3 months ago

@baentsch I can take a look ?

At what?

loganaden commented 3 months ago

We can take a look at fixing the problem if @SWilson4 hasn't already done so ?

baentsch commented 3 months ago

We can take a look at fixing the problem if @SWilson4 hasn't already done so ?

Ah, OK. Thanks! The question mark confused me.

Indeed, better wait for @SWilson4 -- I think it's simply a cmake version upgrade required.

baentsch commented 3 months ago

Found the reference: https://github.com/open-quantum-safe/liboqs/issues/1748

SWilson4 commented 3 months ago

We can take a look at fixing the problem if @SWilson4 hasn't already done so ?

Ah, OK. Thanks! The question mark confused me.

Indeed, better wait for @SWilson4 -- I think it's simply a cmake version upgrade required.

A downgrade, unfortunately :(

baentsch commented 3 months ago

A downgrade, unfortunately :(

That's not good. Is this then a known bug/something that has been reported to the cmake team at all?

SWilson4 commented 3 months ago

Turns out that it's not really a regression, just a behaviour change that broke our CMake config. See https://github.com/open-quantum-safe/liboqs/issues/1748#issuecomment-2256628489 and https://github.com/open-quantum-safe/liboqs/pull/1873.

SWilson4 commented 3 months ago

We can take a look at fixing the problem if @SWilson4 hasn't already done so ?

If you could test my fix in whatever error-triggering setup you have, that would be fantastic.

loganaden commented 3 months ago

Tested and it fixes the issue.

Successfully built liboqs-python Installing collected packages: nose2, liboqs-python Successfully installed liboqs-python-0.10.0 nose2-0.15.1 Removing intermediate container 7563a817b7d0 ---> 73e2688dcb34 Successfully built 73e2688dcb34 Successfully tagged oqs-python:latest

`liboqs version: 0.10.2-dev liboqs-python version: 0.10.0 Enabled KEM mechanisms: ['BIKE-L1', 'BIKE-L3', 'BIKE-L5', 'Classic-McEliece-348864', 'Classic-McEliece-348864f', 'Classic-McEliece-460896', 'Classic-McEliece-460896f', 'Classic-McEliece-6688128', 'Classic-McEliece-6688128f', 'Classic-McEliece-6960119', 'Classic-McEliece-6960119f', 'Classic-McEliece-8192128', 'Classic-McEliece-8192128f', 'HQC-128', 'HQC-192', 'HQC-256', 'Kyber512', 'Kyber768', 'Kyber1024', 'ML-KEM-512-ipd', 'ML-KEM-512', 'ML-KEM-768-ipd', 'ML-KEM-768', 'ML-KEM-1024-ipd', 'ML-KEM-1024', 'sntrup761', 'FrodoKEM-640-AES', 'FrodoKEM-640-SHAKE', 'FrodoKEM-976-AES', 'FrodoKEM-976-SHAKE', 'FrodoKEM-1344-AES', 'FrodoKEM-1344-SHAKE']

SWilson4 commented 3 months ago

Tested and it fixes the issue.

I'll close this PR, then, and will do the same with the related issue when open-quantum-safe/liboqs#1873 lands. Thanks for reporting the bug and testing the fix!