open-quantum-safe / liboqs-python

Python 3 bindings for liboqs
https://openquantumsafe.org/
MIT License
122 stars 45 forks source link

provide an alternate method to set liboqs installation path #93

Closed vppillai closed 3 weeks ago

vppillai commented 3 weeks ago

Adding an alternate method (OQS_INSTALL_PATH) to specify the LIBOQS installation path.

SWilson4 commented 2 weeks ago

Hi @vppillai, is there a reason you closed this PR? It seems to me like a useful feature to support.

vppillai commented 2 weeks ago

Hi Spencer, I forgot to sign the commits and and pre merge tested were complaining. Cancelled it thinking of taking the easy route of raising a new PR on a clean fork, but got sidetracked with other stuff.

Let me raise a new PR with a clean fork later today. Sorry about the confusion. I should have left a message in the PR before I closed it.

Cheers, Vysakh

On Wed, Oct 30, 2024, 7:36 a.m. Spencer Wilson @.***> wrote:

Hi @vppillai https://github.com/vppillai, is there a reason you closed this PR? It seems to me like a useful feature to support.

— Reply to this email directly, view it on GitHub https://github.com/open-quantum-safe/liboqs-python/pull/93#issuecomment-2447365241, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA3XJSTK3LME5T2LNDXMWKLZ6DVHTAVCNFSM6AAAAABQQE67BOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINBXGM3DKMRUGE . You are receiving this because you were mentioned.Message ID: @.***>

vppillai commented 2 weeks ago

raised https://github.com/open-quantum-safe/liboqs-python/pull/95